Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mesh scale option #120

Closed
ManevilleF opened this issue Oct 25, 2023 · 0 comments · Fixed by #121
Closed

Add mesh scale option #120

ManevilleF opened this issue Oct 25, 2023 · 0 comments · Fixed by #121
Labels
enhancement New feature or request usability Make the APIs easier to use

Comments

@ManevilleF
Copy link
Owner

Is your feature request related to a problem? Please describe.
Mesh generation, through plane and column builder are missing a scaling option

Describe the solution you'd like
Both builder should have an optional Vec2/Vec3 scale factor
@ManevilleF ManevilleF added enhancement New feature or request usability Make the APIs easier to use labels Oct 25, 2023
@ManevilleF ManevilleF mentioned this issue Oct 25, 2023
Merged
ManevilleF added a commit that referenced this issue Oct 26, 2023
@ManevilleF
Mesh can be scaled (#121)
2c0312a 
> Closes #120 

# Work done

* Added `PlaneMeshBuilder::with_scale` option to scale generated mesh
* Added `ColumnMeshBuilder::with_scale` option to scale generated mesh

The scale factor is applied before the rotation and offset, and I don't
know if the API is clear enough or if it's the right way to do it.
Maybe it should be called `local_scale` ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request usability Make the APIs easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mesh can be scaled ManevilleF/hexx
1 participant
@ManevilleF