We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In my email layout I have a very simple image tag which points to amazon s3.
<img src="http://s3.amazonaws.com/bucket/image.jpg">
When roadie is install this url gets converted to this:
<img src="http://s3.amazonaws..com/bucket/image.jpg">
[Note the additional "." before com]
The text was updated successfully, but these errors were encountered:
I cannot replicate this.
rendering('<img src="http://s3.amazonaws.com/bucket/image.jpg">').should have_attribute('src' => 'http://s3.amazonaws.com/bucket/image.jpg')
This test passes. The implementation is also using the built-in URI class to check that the URL is relative, and it should not be relative.
URI
# Other details removed uri = URI.parse(url) if uri.relative? # should be false make_uri_absolute else uri.to_s # should work end
So unless URI is buggy in your Ruby (and either returns true on relative? or generates an incorrect URL with to_s), the fault lies somewhere else.
relative?
to_s
Which version of Ruby are you using? Does it happen for any http://s3.amazonaws.com URL? Is there some funky characters in the true URL?
http://s3.amazonaws.com
Sorry, something went wrong.
Closing this due to inactivity.
No branches or pull requests
In my email layout I have a very simple image tag which points to amazon s3.
When roadie is install this url gets converted to this:
[Note the additional "." before com]
The text was updated successfully, but these errors were encountered: