Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black tray icon is barely visible in gnome #1463

Closed
1 task done
mixtur opened this issue Aug 12, 2024 · 8 comments · Fixed by #1501
Closed
1 task done

black tray icon is barely visible in gnome #1463

mixtur opened this issue Aug 12, 2024 · 8 comments · Fixed by #1501
Assignees
Labels
bug Something isn't working platform:linux Related to linux build

Comments

@mixtur
Copy link

mixtur commented Aug 12, 2024

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

When there are active notifications the icon becomes green and its clearly visible, by when not - it is black and I can't even tell if the app is running or not.

Maybe make default icon white on dark themes. Or add white background or shadow below the icon.

🪜 Steps To Reproduce

Start the app on any recent Ubuntu with Gnome and dark theme.

Gitify Version

5.12.1

Operating System

Linux

GitHub Account

GitHub Cloud

📸 Screenshots

image

@mixtur mixtur added the bug Something isn't working label Aug 12, 2024
@setchy setchy added the platform:linux Related to linux build label Aug 12, 2024
@setchy
Copy link
Member

setchy commented Aug 14, 2024

Thanks for reporting @mixtur - certainly not by design, so we'll look to fix asap 😄

Would you sharing a screenshot of the Gitify window with the appearance setting set as System. I don't have readily access to a Ubuntu machine to confirm myself.

@mixtur
Copy link
Author

mixtur commented Aug 14, 2024

With new notification
image
Without notifications
image

@setchy
Copy link
Member

setchy commented Aug 14, 2024

Thank you for the quick response.

Perhaps we can add some special handling for platform === linux, nativeTheme === DARK to use a custom tray icon 🤔.

On other platforms, like macOS, the icon seems to automagically be inverted based on the theme

@mixtur
Copy link
Author

mixtur commented Aug 14, 2024

Thank you for the quick response.

Thank you for Gitify:) That is why I respond fast

@setchy
Copy link
Member

setchy commented Aug 14, 2024

Is it fair to assume that when using light system theme on Ubuntu, the Gitify tray icons are visible?

@mixtur
Copy link
Author

mixtur commented Aug 14, 2024

Just tried it. The answer is no.

Many parts of the interface indeed become white on white theme, but not the top bar for some reason.

Maybe I am not representative.

I can only speak for what I see. I am on Ubuntu 24.04 LTS. There is also Gnome Tweaks installed on my system. It might mess with the theme.
Don't know what will happen on stock Ubuntu.

@mixtur
Copy link
Author

mixtur commented Aug 16, 2024

Noted that the icon in main menu is very visible. Maybe some variation of that could work.
image

@setchy
Copy link
Member

setchy commented Aug 20, 2024

Over the weekend I setup a Ubuntu Desktop VM and was able to reproduce

Screenshot 2024-08-19 at 10 07 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform:linux Related to linux build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants