Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unit tests #25

Closed
adamdawkins opened this issue Mar 2, 2016 · 3 comments
Closed

Generate unit tests #25

adamdawkins opened this issue Mar 2, 2016 · 3 comments

Comments

@adamdawkins
Copy link

Can we have the cli generate associated test files too? It's probably one of the files with the most setup.

We could generate the outer describe and add a pending test that would be picked up.

As a side, is there a reason all test-related features have been left out of the CLI scaffolds? If it's a key component of the Mantra spec, shouldn't the CLI also generate these files?

@sungwoncho
Copy link

There is no good reason test is left out of the CLI; it simply hasn't been implemented yet.

I like the idea of generating a pending test. I made a new branch test. Let's start on that branch. PR is welcomed.

We will need to modify the create command and the generators for 'actions', 'containers,' and 'components.' Also we need to add a way to run the tests in package.json. Let's follow the example on https://github.com/mantrajs/mantra-sample-blog-app.

@adamdawkins
Copy link
Author

@sungwoncho Great, I'll try and find some time to help out with this soon

@sungwoncho
Copy link

Implemented and released in v0.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants