Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpage: specify letter page size in CSS #107

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Feb 1, 2018

Closes #105

At least for the Sci-Hub manuscript this change increased the length (number of pages). See the letter manuscript at manuscript.pdf.

Changing to letter by default seems okay. In the usage we can note or link to instructions for setting it back to A4.

@agitter going to skip adding instructions to USAGE, since I'm not sure of our longterm plans regarding the CSS and how it should be edited. Also hopefully users will be able to now more easily search for #105 if they're curious.

@agitter
Copy link
Member

agitter commented Feb 1, 2018

going to skip adding instructions to USAGE

Okay, sounds good to me.

@dhimmel dhimmel merged commit a535f7b into manubot:master Feb 1, 2018
@dhimmel dhimmel deleted the page-size branch February 1, 2018 11:55
dhimmel added a commit that referenced this pull request Feb 1, 2018
This build is based on
a535f7b.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/336065283
https://travis-ci.org/greenelab/manubot-rootstock/jobs/336065284

[ci skip]

The full commit message that triggered this build is copied below:

Webpage: specify letter page size in CSS (#107)

Closes #105
dhimmel added a commit that referenced this pull request Feb 1, 2018
This build is based on
a535f7b.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/336065283
https://travis-ci.org/greenelab/manubot-rootstock/jobs/336065284

[ci skip]

The full commit message that triggered this build is copied below:

Webpage: specify letter page size in CSS (#107)

Closes #105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants