Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newtypes for app id, asset id, tx id #160

Open
ivnsch opened this issue Apr 12, 2022 · 5 comments
Open

Newtypes for app id, asset id, tx id #160

ivnsch opened this issue Apr 12, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@ivnsch
Copy link
Contributor

ivnsch commented Apr 12, 2022

It seems convenient to have types for these ids (similar to e.g. Round)
@manuelmauro
Copy link
Owner

It seems like a good idea!

@ivnsch ivnsch added the good first issue Good for newcomers label May 15, 2022
@Niceural
Copy link

from the documentation it seems that app id, asset id, and tx id are of type uint64. Do we want something like type AppId = uint64;?

@ivnsch
Copy link
Contributor Author

ivnsch commented Nov 22, 2022

I'd use a tuple struct, which gives us type safety for free.

@Niceural
Copy link

thanks for the guidance, will give it a go!

@xpanvictor
Copy link

is this still in progress, want to try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ivnsch @manuelmauro @xpanvictor @Niceural