Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): setup #6

Merged
merged 24 commits into from
Jun 21, 2023
Merged

test(integration): setup #6

merged 24 commits into from
Jun 21, 2023

Conversation

byeongsu-hong
Copy link
Collaborator

@byeongsu-hong byeongsu-hong commented Jun 6, 2023

resolves MITO-18
resolves MITO-110

  • nodes
    • osmo -> test-tube
    • evm -> anvil
  • test contracts
    • test-mock-ism
    • test-mock-msg-receiver
  • bech32
    • applied to parse logic in Message receiver
    • hpl-interface/types/lib.rs
  • testing
    • evm_mailbox <-> cw_mailbox
    • TBD...

@byeongsu-hong byeongsu-hong marked this pull request as ready for review June 20, 2023 12:45
Copy link
Contributor

@hashableric hashableric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write some comment on testing codes. hard to figure out whats your purpose is. @byeongsu-hong

Comment on lines 54 to 61
#[tokio::test]
async fn test_setup() {
let test_env = setup_env().await.unwrap();

println!("{:?}", test_env.cw_deployments.addrs);
println!("{:?}", test_env.cw_deployments.codes);
println!("{:?}", test_env.evm_deployments);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove stdio macros in test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added this test to check the address of deployments

@hashableric hashableric self-requested a review June 20, 2023 13:26
Copy link
Contributor

@hashableric hashableric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please make ci pass. @byeongsu-hong

Copy link
Contributor

@steve806 steve806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@linear
Copy link

linear bot commented Jun 20, 2023

@linear
Copy link

linear bot commented Jun 20, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0652e3e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   56.92%           
=======================================
  Files           ?       39           
  Lines           ?     1393           
  Branches        ?        0           
=======================================
  Hits            ?      793           
  Misses          ?      600           
  Partials        ?        0           

@byeongsu-hong byeongsu-hong merged commit 47e666f into main Jun 21, 2023
@byeongsu-hong byeongsu-hong deleted the feat/integration-test branch June 21, 2023 05:21
byeongsu-hong added a commit that referenced this pull request Jan 25, 2024
* Add pausable ism with tests

* Fix paused query error case

* Run CI against all PRs

* Add pausable ISM to README

* Build wasm

* Fix scripts

* Allow threshold == set size and add tests

* Upload artifacts

* Force

* Move into makefile

* Install rename

* Rename properly

* Update test.yaml

* Fix renaming

* Fix makefile indentation

* Force cargo install

* simple fee hook (#6)

* Implement simple fee hook

* Address pr comments

* Fix unit tests

* Make set fee only owner

* Implement remaining unit tests

* Fix merkle integration test use

---------

Co-authored-by: nambrot <nambrot@googlemail.com>
Co-authored-by: ByeongSu Hong <hong@byeongsu.dev>

* Add mailbox unit tests for post dispatch (#7)

* Add mailbox unit tests for post dispatch

* Add test for different denoms

---------

Co-authored-by: nambrot <nambrot@googlemail.com>
Co-authored-by: ByeongSu Hong <hong@byeongsu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants