-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mailbox unit tests for post dispatch #91
Merged
byeongsu-hong
merged 22 commits into
many-things:main
from
hyperlane-xyz:main-conflicts-resolution
Jan 25, 2024
Merged
Add mailbox unit tests for post dispatch #91
byeongsu-hong
merged 22 commits into
many-things:main
from
hyperlane-xyz:main-conflicts-resolution
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pausable ISM
Allow threshold == set size and add tests
* Implement simple fee hook * Address pr comments * Fix unit tests * Make set fee only owner * Implement remaining unit tests * Fix merkle integration test use --------- Co-authored-by: nambrot <nambrot@googlemail.com> Co-authored-by: ByeongSu Hong <hong@byeongsu.dev>
* Add mailbox unit tests for post dispatch * Add test for different denoms
yorhodes
changed the title
Add mailbox unit tests for post dispatc
Add mailbox unit tests for post dispatch
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 67.66% 67.76% +0.09%
==========================================
Files 87 87
Lines 5224 5234 +10
Branches 5224 5234 +10
==========================================
+ Hits 3535 3547 +12
+ Misses 1301 1299 -2
Partials 388 388 ☔ View full report in Codecov by Sentry. |
byeongsu-hong
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replay hyperlane-xyz#7 upstream