Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailbox unit tests for post dispatch #91

Merged

Conversation

yorhodes
Copy link
Contributor

@yorhodes yorhodes commented Jan 23, 2024

Replay hyperlane-xyz#7 upstream

The mailbox doesnt enforce default hook fees following #86
This PR adds unit tests to the new mailbox behavior and ensures that required hook fees are appropriately enforced

@yorhodes yorhodes changed the title Merge upstream Add mailbox unit tests for post dispatc Jan 23, 2024
@yorhodes yorhodes changed the title Add mailbox unit tests for post dispatc Add mailbox unit tests for post dispatch Jan 23, 2024
@yorhodes yorhodes marked this pull request as ready for review January 23, 2024 23:02
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa5539e) 67.66% compared to head (2682b71) 67.76%.

Files Patch % Lines
contracts/core/mailbox/src/execute.rs 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   67.66%   67.76%   +0.09%     
==========================================
  Files          87       87              
  Lines        5224     5234      +10     
  Branches     5224     5234      +10     
==========================================
+ Hits         3535     3547      +12     
+ Misses       1301     1299       -2     
  Partials      388      388              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byeongsu-hong byeongsu-hong self-requested a review January 25, 2024 06:45
@byeongsu-hong byeongsu-hong merged commit 6595945 into many-things:main Jan 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants