Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a revision on hackage to support GHC 9.0 #32

Closed
1 task done
andreasabel opened this issue Feb 8, 2021 · 4 comments · Fixed by #33
Closed
1 task done

Make a revision on hackage to support GHC 9.0 #32

andreasabel opened this issue Feb 8, 2021 · 4 comments · Fixed by #33

Comments

@andreasabel
Copy link
Contributor

andreasabel commented Feb 8, 2021

GHC 9.0 was released. lifted-async does not build because of the constraint on base.
I successfully tried:

cabal install --allow-newer lifted-async

I suggest to make a revision on hackage (https://hackage.haskell.org/package/lifted-async/maintain) that lifts the necessary upper bounds to allow compilation with GHC 9.0.

UPDATE:

@maoe
Copy link
Owner

maoe commented Feb 9, 2021

Thanks for reporting.

I'm waiting for a dependency to be updated. The constraints package cannot build with 9.0.1 because the hashable package needs to be revised.

@andreasabel
Copy link
Contributor Author

I successfully tested building lifted-async-0.10.1.2 just now with a relaxed upper bound on base (see below [1]).

So a new release does not seem necessary, just a revision of metadata on hackage.
https://github.com/haskell-infra/hackage-trustees/blob/master/cookbook.md#best-practice-for-managing-meta-data

E.g. here is my workflow for revisions: https://github.com/haskell-pkg-janitors/haskell-src/blob/540fc48dc2f0f2c75699315df950ff26e1918270/CONTRIBUTING.md

But it seems you are also planning to fix some warnings in #33, so this is of course not suitable for a revision...

[1] build test:

lifted-async-0.10.1.2$ cabal test
Resolving dependencies...
Build profile: -w ghc-9.0.1 -O1
In order, the following will be built (use -v for more details):
 - haskell-src-exts-1.23.1 (lib) (requires build)
 - semigroups-0.19.1 (lib) (requires build)
 - tasty-1.4.1 (lib) (requires build)
 - constraints-0.12 (lib) (requires build)
 - tasty-expected-failure-0.12.3 (lib) (requires download & build)
 - tasty-th-0.1.7 (lib) (requires download & build)
 - tasty-hunit-0.10.0.3 (lib) (requires build)
 - lifted-async-0.10.1.2 (lib) (first run)
 - lifted-async-0.10.1.2 (test:test-lifted-async) (first run)
 - lifted-async-0.10.1.2 (test:regression-tests) (first run)
...
Test suite test-lifted-async: RUNNING...
Test suite test-lifted-async: PASS
...
Test suite regression-tests: RUNNING...
Test suite regression-tests: PASS

@maoe maoe closed this as completed in #33 Feb 26, 2021
@maoe
Copy link
Owner

maoe commented Feb 26, 2021

Sorry for the delay. Just uploaded https://hackage.haskell.org/package/lifted-async-0.10.1.3.

@andreasabel
Copy link
Contributor Author

Excellent, thank you! Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants