Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MADmin Walker settings bugged "Back to editor" link. #338

Closed
sebastienvercammen opened this issue Aug 18, 2019 · 1 comment
Closed

MADmin Walker settings bugged "Back to editor" link. #338

sebastienvercammen opened this issue Aug 18, 2019 · 1 comment

Comments

@sebastienvercammen
Copy link

sebastienvercammen commented Aug 18, 2019

Environment:

  • dev branch, this commit (0d97dc2)
  • py3.7
  • Raspbian Buster

Steps to reproduce:

  1. Open MADmin's "Walker" settings tab.
  2. On the Basedata of one of the walkers, click Edit.
  3. In the Basedata, on one of the assigned areas, click Edit.
  4. Top left corner of the screen, click "Back to editor".

Problem: This links to http://host:port/showsettings?area=, an empty area name, causing an empty editor screen.

image

To fix:
Link back to the "Walker" settings.

Can be the generic /showsettings?area=walker for a quick fix, or the specific selected Walker's settings.

@sn0opy
Copy link
Collaborator

sn0opy commented Aug 19, 2019

Going to close this one, since this is going to change with the madmin rework anyway

@sn0opy sn0opy closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants