Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ci errors #86

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Fix/ci errors #86

merged 3 commits into from
Feb 15, 2019

Conversation

werrolf
Copy link
Contributor

@werrolf werrolf commented Feb 15, 2019

Fixes initial composer install to skip (failing) asset setup.
Adds build-bootstrap to prevent app/console fatalities due to missing bootstrap.php.cache, which arise from previous change.
Fixes composer project-name failing on branch names without slash (such as 'master'). This fixes collateral tar errors. Empty project-name output produces an artifact name with a leading dash, which tar complains about as an unknown option.
Removes the repeated second short commit hash from the artifact name. C.f.:

$ echo "$(git describe --tags)-$(git rev-parse --short HEAD)"
v3.0.7.7-14-g3fd1b33-3fd1b33
$ echo "$(git describe --tags HEAD)"
v3.0.7.7-14-g3fd1b33

The short commit hash 3fd1b33 is part of the describe output anyway.

@werrolf werrolf merged commit 7362e4f into master Feb 15, 2019
@werrolf werrolf deleted the fix/ci-errors branch February 28, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant