Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Add icon option for third level items in NavigationAccordion #252

Merged
merged 8 commits into from
Feb 24, 2020

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Feb 13, 2020

This PR:

  • adds an icon option for third level items. This option accepts a maki icon value.
  • added test-case only css to set the max-width of NavigationAccordion to 400px (which is the max-width the component usually sees on the page) - this will help catch layout issues a little better.

Fixes #235

image

How to review

  1. npm start
  2. Navigate to /NavigationAccordion
  3. Test Shows third level items with icons test case.

I also copied this component as a test in /mapbox-gl-js-docs:

  1. Open /mapbox-gl-js-docs locally, pull down the nav-accordion-test branch.
  2. yarn install
  3. yarn start
  4. Visit /mapbox-gl-js/style-spec/layers/#fill-extrusion to check the icons on the layer's page.

QA Checklist

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • IE11, no errors logged to console.
    - [ ] Mobile Safari, no errors logged to console. not applicable
    - [ ] Android Chrome, no errors logged to console. not applicable

@katydecorah
Copy link
Contributor Author

This is almost ready, I'm waiting for access to BrowserStack to test in IE.

@katydecorah katydecorah changed the title add icon option for third level items in NavigationAccordion Add icon option for third level items in NavigationAccordion Feb 20, 2020
@katydecorah katydecorah added this to the 0.27.0 milestone Feb 20, 2020
Katy DeCorah added 2 commits February 20, 2020 17:10
* master:
  Scroll to active item in NavigationAccordion onload (#247)
Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I tested in IE11 and things are rendering well and I'm not seeing any errors.

image

Katy DeCorah added 3 commits February 24, 2020 10:15
* master:
  Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254)
  Update PULL_REQUEST_TEMPLATE.md (#258)
@katydecorah katydecorah merged commit 2ac80c7 into master Feb 24, 2020
@katydecorah katydecorah deleted the navacc-icon branch February 24, 2020 15:19
katydecorah pushed a commit that referenced this pull request Feb 26, 2020
* master:
  Add `icon` option for third level items in NavigationAccordion (#252)
  Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254)
  Update PULL_REQUEST_TEMPLATE.md (#258)
katydecorah pushed a commit that referenced this pull request Feb 26, 2020
* master:
  Add tests to assert Segment event in Feedback component (#256)
  Add `icon` option for third level items in NavigationAccordion (#252)
  Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254)
  Update PULL_REQUEST_TEMPLATE.md (#258)
  Scroll to active item in NavigationAccordion onload (#247)
  Scroll to active item in SectionedNavigation (#249)
katydecorah pushed a commit that referenced this pull request Jun 9, 2020
* master: (50 commits)
  0.29.1
  Update CHANGELOG.md
  Remove `limiter` from Topbar (#282)
  0.29.0
  Prepare 0.29.0
  Allow Kotlin-only activities (#278)
  0.28.0
  Prepare 0.28.0
  Prevent `ProductMenu` from truncating `tag` (#277)
  Update mr-ui and npm audit (#266)
  Add `Topbar` component (#274)
  Fix bug in NumberedCodeSnippet (#268)
  Update issue templates
  Fix padding and background on NumberedCodeSnippet (#269)
  Prepare 0.27.0
  Update Sentry
  Send basic user metadata along with Feedback (#255)
  Set character limit for `Feedback` texteara (#244)
  Add tests to assert Segment event in Feedback component (#256)
  Add `icon` option for third level items in NavigationAccordion (#252)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon feature for NavigationAccordion
2 participants