This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Add icon
option for third level items in NavigationAccordion
#252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Scroll to active item in SectionedNavigation (#249)
…make limit navacc width
This is almost ready, I'm waiting for access to BrowserStack to test in IE. |
katydecorah
changed the title
add
Add Feb 20, 2020
icon
option for third level items in NavigationAccordionicon
option for third level items in NavigationAccordion
* master: Scroll to active item in NavigationAccordion onload (#247)
danswick
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
katydecorah
pushed a commit
that referenced
this pull request
Feb 26, 2020
* master: Add tests to assert Segment event in Feedback component (#256) Add `icon` option for third level items in NavigationAccordion (#252) Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254) Update PULL_REQUEST_TEMPLATE.md (#258) Scroll to active item in NavigationAccordion onload (#247) Scroll to active item in SectionedNavigation (#249)
katydecorah
pushed a commit
that referenced
this pull request
Jun 9, 2020
* master: (50 commits) 0.29.1 Update CHANGELOG.md Remove `limiter` from Topbar (#282) 0.29.0 Prepare 0.29.0 Allow Kotlin-only activities (#278) 0.28.0 Prepare 0.28.0 Prevent `ProductMenu` from truncating `tag` (#277) Update mr-ui and npm audit (#266) Add `Topbar` component (#274) Fix bug in NumberedCodeSnippet (#268) Update issue templates Fix padding and background on NumberedCodeSnippet (#269) Prepare 0.27.0 Update Sentry Send basic user metadata along with Feedback (#255) Set character limit for `Feedback` texteara (#244) Add tests to assert Segment event in Feedback component (#256) Add `icon` option for third level items in NavigationAccordion (#252) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
icon
option for third level items. This option accepts a maki icon value.Fixes #235
How to review
npm start
Shows third level items with icons
test case.I also copied this component as a test in /mapbox-gl-js-docs:
nav-accordion-test
branch.yarn install
yarn start
QA Checklist
5.7.0
.Open the test cases app locally on:
- [ ] Mobile Safari, no errors logged to console.not applicable- [ ] Android Chrome, no errors logged to console.not applicable