Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Make NavigationAccordion, SectionedAccordion, and PageLayout>sidebarTitle line up #254

Merged
merged 7 commits into from
Feb 21, 2020

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Feb 20, 2020

This PR makes sure all sidebar items are lined up:

Current Proposed
image image
image image

How to review

  1. npm start
  2. Navigate to /NavigationAccordion, /SectionedNavigation; /Feedback as a nice PageLayout example that you can preview

I also copied this component as a test in /mapbox-gl-js-docs:

  1. Open /mapbox-gl-js-docs locally, pull down the nav-accordion-test branch.
  2. yarn install
  3. yarn start
  4. Visit every /overview, /api, /examples to make sure all sidebar items are lined up.

QA Checklist

  • No errors logged to console.
  • Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: 7.5.0. Tested a few pages and didn't get 100% due to NavigationDropdown, SectionedNavigation - Form elements do not have associated labels #248 and test-cases app having the docs Id baked in:
    • SectionedNavigation - 90
    • PageLayout - 90
    • NavigationAccordion - 91
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.
  • If applicable, create a PR in a site repo, copy the component, and test it. Push to staging and instruct the reviewer to test the component in-page.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • IE11, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

@katydecorah katydecorah added this to the 0.27.0 milestone Feb 20, 2020
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

Katy DeCorah added 3 commits February 20, 2020 17:10
* master:
  Scroll to active item in NavigationAccordion onload (#247)
* master:
  Update PULL_REQUEST_TEMPLATE.md (#258)
@katydecorah katydecorah merged commit 3d9d986 into master Feb 21, 2020
@katydecorah katydecorah deleted the navacc-spacing branch February 21, 2020 17:07
katydecorah pushed a commit that referenced this pull request Feb 24, 2020
* master:
  Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254)
  Update PULL_REQUEST_TEMPLATE.md (#258)
katydecorah pushed a commit that referenced this pull request Feb 26, 2020
* master:
  Add `icon` option for third level items in NavigationAccordion (#252)
  Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254)
  Update PULL_REQUEST_TEMPLATE.md (#258)
katydecorah pushed a commit that referenced this pull request Feb 26, 2020
* master:
  Add tests to assert Segment event in Feedback component (#256)
  Add `icon` option for third level items in NavigationAccordion (#252)
  Improve text alignment of sidebar including `NavigationAccordion`, `SectionedNavigation`, and `PageLayout` `sidebarTitle` (#254)
  Update PULL_REQUEST_TEMPLATE.md (#258)
  Scroll to active item in NavigationAccordion onload (#247)
  Scroll to active item in SectionedNavigation (#249)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationAccordion has uneven spacing
2 participants