-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to sint32 for coords #24
Comments
Actually, if we use delta encoding, we need |
From my testing, using I'm in favor of this change. |
@brendan-ward interesting! one more reason to switch to protocol-buffers. The size different will be huge once we do #23. |
@mourner there's no difference in the on-wire represenation between sint32 and sint64. The only difference is for implementations, e.g. Google's Protobuf implementation provides a int64 when decoding (and requires one when encoding). For JavaScript implementations, there should be no difference since all numbers are stored as doubles anyway (or as int32 if they're small integers, depending on the JS implementation). |
@kkaefer yeah, I originally meant |
Closing in favor of #27 |
Since we use
1e6
encoding, it might make sense to switch coords fromint64
toint32
for better geometry compression.int32
range is-2147,483,648
through2147,483,647
, which is plenty of headroom for the usual-180..180
plus a handful of repeating worlds. We probably should not care about other CRS because it's going to be ditched out of the GeoJSON spec.The text was updated successfully, but these errors were encountered: