Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agentkeepalive on https? #40

Closed
ianshward opened this issue Oct 2, 2019 · 1 comment
Closed

agentkeepalive on https? #40

ianshward opened this issue Oct 2, 2019 · 1 comment

Comments

@ianshward
Copy link
Member

It looks like agentkeepalive is not used on HTTPS requests - this might be a relic from the past, when there was not support for HTTPS clients in agentkeepalive.

// Don't use keepalive agent for https.
params.agent = uri.indexOf('https') === 0 ? null : agent;

This is just something I noticed when reviewing a recent PR, and therefore created this separate issue about it.

@DzmitryU @springmeyer

@rmrice
Copy link
Contributor

rmrice commented Dec 19, 2019

Fixed in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants