Don't attempt to clear "undefined" sources #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If layers without sources (e.g. a 'background' layer) are removed-and-re-added in a single style update batch, we previously attempted to clear their source. This results in an NPE that crashes the application.
jfirebaugh
added a commit
to mapbox/mapbox-gl-test-suite
that referenced
this pull request
Jan 7, 2017
jfirebaugh
approved these changes
Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I upgraded from mapbox 0.28.0 to 0.30.0 I noticed that when my application tried to "update" a
background-type layer I got an NPE. The root cause seems to be that when a background layer is removed-and-added in a single batched style update group its source gets marked for "clear"-ing.This sucks because
layer.source === undefinedforbackgroundlayers, and whenstyle.js#283attempts to call_clearSourceonundefinedit throws an exception.