OnMapClick() and onLocationLayerClick are called one by one

[samoilovich]

Hello

My app has the map. I need to handle clicks on the location marker (blue point for current location) on the map. For the location marker I use custom icon (don't know if it is important or not).
My map has OnMapClickListener and OnLocationLayerClickListener.
And onMapClick() and onLocationLayerClick() are called one by one (both!) if I click on the location marker.
But I need that onMapClick() is not called if I click on the location marker cause it leads to unexpected behavior.

mapbox sdk: com.mapbox.mapboxsdk:mapbox-android-sdk:6.1.1
location layer plugin: com.mapbox.mapboxsdk:mapbox-android-plugin-locationlayer:0.5.2
device: Sumsumg S7 edge. android version 7.0

Could you help with that?
Please let me know if you need any info about code or steps to reproduce.

Thanks

[tobrun]

@samoilovich thank you for reporting this issue, the OnLocationLayerClickListener itself uses an OnMapClickListener. It's expected that this will happen though it's not ideal. To solve this, I'm proposing to change the signature of void OnMapClick to boolean OnMapClick. This would allow a component as a plugin to indicate to the SDK to not further notifty other OnMapClick listeners.

Will have to tag this as a SemVer change as we are changing public API with this one.

cc @LukasPaczos @cammace

[tobrun]

Landed with #13237