Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Option to consume map clicks, consuming location clicks #13205

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Option to consume map clicks, consuming location clicks #13205

merged 1 commit into from
Oct 29, 2018

Conversation

LukasPaczos
Copy link
Member

Closes #12011.

@LukasPaczos LukasPaczos added Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Oct 26, 2018
@LukasPaczos LukasPaczos added this to the android-v7.0.0 milestone Oct 26, 2018
tobrun
tobrun approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples were updated with returning false. Doesn't true, indicating the event was fully consumed, make more sense for these examples?

@LukasPaczos
Copy link
Member Author

@tobrun opted to return false to not alter logic in those examples. We can change those as needed when updating/refactoring examples.

@LukasPaczos LukasPaczos merged commit 434f186 into android-semver Oct 29, 2018
@LukasPaczos LukasPaczos deleted the lp-12011-location-click-duplicates branch October 29, 2018 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Milestone
android-v7.0.0-iowaska
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasPaczos @tobrun