You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Capturing from #12696 (comment) that Improve this map in the attribution dialog is always displayed in english. The root cause of this, is that we extract this value from the used sources on the map. To fix this we need to add a new resource to our string resources, provide translations on transifex and replace the anchor value of the returned html by the source by the a label in the correct language.
Neither the iOS and macOS map SDKs localizes the “Improve This Map” attribution item that comes from the Mapbox Streets source. (We used to localize a hardcoded attribution item until we started pulling it from the source.) In my opinion, it should be the source’s responsibility to localize the attribution items, because the titles can contain any arbitrary HTML. mapbox/tilejson-spec#20 would bring some much-needed structure to TileJSON, which would unblock localizing attribution items server-side just as we localize map labels server-side.
If the developer needs to work around the unlocalized item in the meantime, consider adding a callback for the developer to customize the title of any link given its URL or class.
Thanks for the additional information on iOS/macOS @1ec5
If the developer needs to work around the unlocalized item in the meantime, consider adding a callback for the developer to customize the title of any link given its URL or class.
This is already possible, a user can roll their own attribution dialog manager which gives them full control over how the attribution should be presented to the user, at this stage they could do the step propoped in OP. @langsmith, how important is this, is this needed in the short term?
China plugin only gets updated when a stable Maps SDK release is made, so perhaps we can try to include this in the next stable Maps SDK release? The f release. That'd be preferable rather than having to wait ~6 weeks for the g release.
Capturing from #12696 (comment) that
Improve this map
in the attribution dialog is always displayed in english. The root cause of this, is that we extract this value from the used sources on the map. To fix this we need to add a new resource to our string resources, provide translations on transifex and replace the anchor value of the returned html by the source by the a label in the correct language.cc @langsmith
The text was updated successfully, but these errors were encountered: