Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Improve this map not translated #12708

Closed
tobrun opened this issue Aug 22, 2018 · 4 comments · Fixed by #12785
Closed

Improve this map not translated #12708

tobrun opened this issue Aug 22, 2018 · 4 comments · Fixed by #12785
Labels
Android Mapbox Maps SDK for Android localization Human language support and internationalization

Comments

@tobrun
Copy link
Member

tobrun commented Aug 22, 2018

Capturing from #12696 (comment) that Improve this map in the attribution dialog is always displayed in english. The root cause of this, is that we extract this value from the used sources on the map. To fix this we need to add a new resource to our string resources, provide translations on transifex and replace the anchor value of the returned html by the source by the a label in the correct language.

cc @langsmith

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Aug 22, 2018
@tobrun tobrun added this to the android-v6.5.0 milestone Aug 22, 2018
@lloydsheng lloydsheng modified the milestones: android-v6.5.0, ios-v4.4.0 Aug 22, 2018
@1ec5 1ec5 added the localization Human language support and internationalization label Aug 22, 2018
@langsmith
Copy link
Contributor

screen shot 2018-08-23 at 7 40 55 am

I've added Improve This Map to Transifex. Waiting for our China team to give me the proper translation to use.

@1ec5
Copy link
Contributor

1ec5 commented Aug 25, 2018

Neither the iOS and macOS map SDKs localizes the “Improve This Map” attribution item that comes from the Mapbox Streets source. (We used to localize a hardcoded attribution item until we started pulling it from the source.) In my opinion, it should be the source’s responsibility to localize the attribution items, because the titles can contain any arbitrary HTML. mapbox/tilejson-spec#20 would bring some much-needed structure to TileJSON, which would unblock localizing attribution items server-side just as we localize map labels server-side.

If the developer needs to work around the unlocalized item in the meantime, consider adding a callback for the developer to customize the title of any link given its URL or class.

@tobrun
Copy link
Member Author

tobrun commented Aug 25, 2018

Thanks for the additional information on iOS/macOS @1ec5

If the developer needs to work around the unlocalized item in the meantime, consider adding a callback for the developer to customize the title of any link given its URL or class.

This is already possible, a user can roll their own attribution dialog manager which gives them full control over how the attribution should be presented to the user, at this stage they could do the step propoped in OP.
@langsmith, how important is this, is this needed in the short term?

@langsmith
Copy link
Contributor

China plugin only gets updated when a stable Maps SDK release is made, so perhaps we can try to include this in the next stable Maps SDK release? The f release. That'd be preferable rather than having to wait ~6 weeks for the g release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android localization Human language support and internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants