This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make improve this map translatable #12785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
added
Android
|
On iOS, we already override the URL to point to the newer feedback tool, so I guess if we’re confident in our feedback link detection to override the URL, we might as well do that for a standard “Improve This Map”. However, if a feedback link happens to have more specific text, I think I’d want to retain that text rather than replace it with a translation of a different string. |
tobrun
force-pushed
the
tvn-improve-this-map
branch
from
a68a968
to
5089490
Compare
LukasPaczos
approved these changes
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12708, follow up from https://github.com/mapbox/mapbox-gl-native/pull/12719/files, this PR hooks into our attribution parser and checks if the our sources contain a "improve this map" anchor and attempt to translate it to a localised language.
@1ec5 do you feel we need to do the same on the iOS side? I follow you on that this should be fixed on the backend though I'm unaware of timings revamping attribution (would love for us to be able to remove this whole html parsing approach).
cc @langsmith @mapbox/maps-ios