Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Incorrect colors at startup #3259

Closed
1ec5 opened this issue Dec 11, 2015 · 10 comments
Closed

Incorrect colors at startup #3259

1ec5 opened this issue Dec 11, 2015 · 10 comments
Labels
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Dec 11, 2015

As of bde07c8, I’m seeing iosapp occasionally launch with a corrupted Streets style:

img_0926

osxapp

Everything goes back to normal upon the very next redraw. At z0, this redraw doesn’t happen until the user manually interacts with the map, but at higher zoom levels, this happens automatically when labels fade in. Still, the corrupted rendering is visible long enough that to the user it’s as though a negative of the map is flashing in.

/cc @jfirebaugh @kkaefer

@1ec5 1ec5 added the bug label Dec 11, 2015
@1ec5 1ec5 added this to the ios-v3.1.0 milestone Dec 11, 2015
@bleege
Copy link
Contributor

bleege commented Dec 14, 2015

There are similar issues in the Android TestApp as well.

/cc @mapbox/mobile

@zugaldia
Copy link
Member

We're also seeing this on Android, including during transitions: https://www.dropbox.com/s/3c2qzlxftogmyld/weird.mp4?dl=0

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 14, 2015

This regression was caused by 93c000d for #3066. The viewport isn’t being set on Android, iOS, or OS X anymore – only on GLFW and HeadlessView.

/cc @kkaefer @adam-mapbox

@jfirebaugh
Copy link
Contributor

As always, there may be multiple issues -- for me this bisected to 45c7b47, which was also my guess beforehand.

@jfirebaugh
Copy link
Contributor

@zugaldia @1ec5 Can you check if 9b8f5d3 fixes the issue?

@zugaldia
Copy link
Member

@jfirebaugh can't reproduce the issue on the Android test app anymore after applying 9b8f5d3

@jfirebaugh
Copy link
Contributor

Great, merged. @1ec5 please reopen if this doesn't also fix the issue on iOS.

@1ec5
Copy link
Contributor Author

1ec5 commented Dec 15, 2015

Looks good in iosapp. Thanks for taking care of this one.

@bleege
Copy link
Contributor

bleege commented Dec 15, 2015

I rebased on my working branch for #3244 (Camera API) and retested. The colors seem to be back on track, although there appears to still be an issue with MapView.setCenterCoordinate() not immediately drawing. I'll keep working on it there though.

@bleege
Copy link
Contributor

bleege commented Dec 15, 2015

Forgot to say... great job diagnosing and solving this yesterday @jfirebaugh @1ec5!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants