Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove REGION_DID_CHANGE Check From Camera Callback #3412

Closed
bleege opened this issue Dec 24, 2015 · 2 comments
Closed

Remove REGION_DID_CHANGE Check From Camera Callback #3412

bleege opened this issue Dec 24, 2015 · 2 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@bleege
Copy link
Contributor

bleege commented Dec 24, 2015

The original Camera API Refinements from #3358 had Callback checks for both REGION_DID_CHANGE_ANIMATED and REGION_DID_CHANGE. The check for REGION_DID_CHANGE was put in for the animateCamera (CameraUpdate update, MapView.CancelableCallback callback) method as it had a 0 time length duration for animation and therefore technically never animated and therefore the Callback was never called. However, this check is leading to some inconsistencies with the full animateCamera (CameraUpdate update, int durationMs, MapView.CancelableCallback callback) method. To solve both problems let's remove the REGION_DID_CHANGE checks in both animateCamera() and easeCamera() AND change the animateCamera() methods sans duration time parameter to use a 1 millisecond duration to trigger the animation functionality but do so in a way that's not noticeable to humans.

/cc @zugaldia

@bleege bleege added the Android Mapbox Maps SDK for Android label Dec 24, 2015
@bleege bleege self-assigned this Dec 24, 2015
@bleege bleege added this to the android-v3.1.0 milestone Dec 24, 2015
bleege added a commit that referenced this issue Dec 24, 2015
…ra methods to 1 millisecond default animation durations
@zugaldia
Copy link
Member

👍

@bleege
Copy link
Contributor Author

bleege commented Dec 24, 2015

@zugaldia I just started a new 3.1.0-SNAPSHOT build on Bitrise. Should be ready in about 30 minutes and will likely be version 3 on the SNAPSHOT repo.

@bleege bleege mentioned this issue Jan 13, 2016
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

3 participants