Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Check for network connectivity before requesting resources #6042

Closed
danswick opened this issue Aug 16, 2016 · 0 comments · Fixed by #6123
Closed

Check for network connectivity before requesting resources #6042

danswick opened this issue Aug 16, 2016 · 0 comments · Fixed by #6123
Assignees
@zugaldia
Labels
Android Mapbox Maps SDK for Android

Comments

@danswick
Copy link
Contributor

Platform: Android
Mapbox SDK version: 4.2.0

Steps to trigger behavior

  1. Cache offline resources.
  2. Turn airplane mode on.
  3. View offline resources.
  4. Note 404 messages in log.

Expected behavior

SDK loads offline resources before attempted to request hosted resources from Mapbox.

Actual behavior

SDK requests resources already in the offline database despite having no network connectivity.

Per discussion with @bleege, we can adapt a similar approach to the one we use in MapboxEventManager for use in HTTPRequest.

cc @zugaldia @bleege @cammace
@cammace cammace added the Android Mapbox Maps SDK for Android label Aug 17, 2016
zugaldia added a commit that referenced this issue Aug 23, 2016
@zugaldia
[android] #6042 - add isConnected() method to MapboxAccountManager to…
939f8af 
… avoid unnecessary HTTPRequests
@zugaldia zugaldia mentioned this issue Aug 23, 2016
Merged
1 task
bleege added a commit that referenced this issue Aug 23, 2016
@bleege
[android] #6042 - Creating IOUtils for common IO functions
707a7b7
zugaldia added a commit that referenced this issue Aug 24, 2016
@zugaldia
[android] #6042 - add null check for mCall to avoid NullPointerException
773776d
zugaldia added a commit that referenced this issue Aug 24, 2016
@zugaldia
[android] #6042 - bring isConnected() to MapboxAccountManager and mak…
9e2aa93 
…e its private SDK use more explicit
zugaldia added a commit that referenced this issue Aug 24, 2016
@zugaldia
[android] #6042 - switch debug level to verbose
883e0e6
zugaldia added a commit that referenced this issue Aug 24, 2016
@zugaldia
[android] #6042 - Check for network connectivity before requesting re…
4579fa0 
…sources
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zugaldia zugaldia

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for network connectivity before requesting resources mapbox/mapbox-gl-native
3 participants
@zugaldia @danswick @cammace