Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Eliminate mbgl/gl/context.hpp include from public includes #8148

Closed
jfirebaugh opened this issue Feb 21, 2017 · 1 comment
Closed

Eliminate mbgl/gl/context.hpp include from public includes #8148

jfirebaugh opened this issue Feb 21, 2017 · 1 comment
Assignees
@kkaefer
Labels
Core The cross-platform C++ core, aka mbgl refactor

Comments

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Feb 21, 2017 •
edited
Loading

mbgl/gl/context.hpp and all of its dependencies are currently forced to be public headers because it is used by SDK files such as native_map_view.cpp in Android and MGLMapView.mm in iOS/macOS.

This needs to be refactored so that mbgl/gl/context.hpp is only exposed internally.
@jfirebaugh jfirebaugh added Core The cross-platform C++ core, aka mbgl refactor labels Feb 21, 2017
@kkaefer kkaefer mentioned this issue Feb 22, 2017
Closed
@kkaefer kkaefer self-assigned this Feb 24, 2017
This was referenced Feb 27, 2017
Merged
Closed
Merged
Merged
Merged
@kkaefer
Copy link
Contributor

kkaefer commented Mar 28, 2017

Fixed in #8214.

@kkaefer kkaefer closed this as completed Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kkaefer kkaefer

Labels
Core The cross-platform C++ core, aka mbgl refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkaefer @jfirebaugh