Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Run full test suite on CI #10333

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Run full test suite on CI #10333

merged 1 commit into from
Oct 31, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Oct 31, 2017

This PR tests if we are able to run all instrumentation tests in a timely fashion. We were recently able to speed up the tests with c9c2e96.

@tobrun
Copy link
Member Author

tobrun commented Oct 31, 2017

screen shot 2017-10-31 at 13 33 27

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Oct 31, 2017
@tobrun tobrun changed the title WIP - run full test suite Run full test suite on CI Oct 31, 2017
@tobrun tobrun added the tests label Oct 31, 2017
@tobrun tobrun requested a review from zugaldia October 31, 2017 20:36
@tobrun
Copy link
Member Author

tobrun commented Oct 31, 2017

Note that full firebase step on Circle CI took 10 minutes:

  • uploading apks to firebase
  • waiting for an available device
  • running the tests
  • downloading the results

screen shot 2017-10-31 at 13 37 42

@tobrun tobrun self-assigned this Oct 31, 2017
@tobrun
Copy link
Member Author

tobrun commented Oct 31, 2017

Adding here that the total build time is something between 16 <-> 20 minutes.
Atm the node build is running for 25 minutes, so I feel this is justifiable.

@tobrun tobrun merged commit 0f1296c into release-agua Oct 31, 2017
@tobrun tobrun deleted the tvn-all-ci-tests branch October 31, 2017 21:14
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Nov 14, 2017
22 tasks
@lilykaiser lilykaiser added this to the android-v5.2.0 milestone Nov 15, 2017
@Guardiola31337 Guardiola31337 mentioned this pull request Nov 17, 2017
23 tasks
@friedbunny
Copy link
Contributor

@tobrun This is now always the longest build on CircleCI, especially for cached rebuilds. For instance, this build took 22:47, while the next-longest was clang-tidy at 11:43.

Can we revisit when and how often we run these tests? 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants