This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Support custom library loader #10733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exposing this makes sense. Will add some javadoc and we can 🚢. |
jaegs
reviewed
Dec 18, 2017
| try { | ||
| System.loadLibrary(name); | ||
| } catch (UnsatisfiedLinkError error) { | ||
| Timber.e(error, "Failed to load native shared library."); |
There was a problem hiding this comment.
Perhaps the catching of the UnsatisfiedLinkError + logging should still happen in LibraryLoader.load() instead of just the DEFAULT implementation.
tobrun
force-pushed
the
jaegs-LibraryLoader
branch
from
6f389b3
to
4c4107e
Compare
tobrun
force-pushed
the
jaegs-LibraryLoader
branch
from
4c4107e
to
a56b51c
Compare
LukasPaczos
approved these changes
Jan 3, 2018
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #10732:
cc @jaegs