This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Accept constant expressions in non-dds properties #11960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
commented
May 21, 2018
| ASSERT_TRUE(result); | ||
| ASSERT_TRUE(result->isConstant()); | ||
| ASSERT_EQ(result->asConstant(), expected); | ||
| } |
There was a problem hiding this comment.
Chose to go with a unit test rather than a render test here, because the latter would quietly cease to guard against regression if whatever currently-non-DDS property we used became DDS.
jfirebaugh
approved these changes
May 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11940
Needs backport to
release-boba