Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

expose moveBy, replace CameraUpdateFactory#scrollBy #13223

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Oct 29, 2018

Closes #13187, need to revisit this approach as this only allows an immediate displacement vs an animation equivalent through the CameraUpdateFactory API.

@tobrun tobrun added Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Oct 29, 2018
@tobrun tobrun added this to the android-v6.7.0 milestone Oct 29, 2018
@tobrun tobrun self-assigned this Oct 29, 2018
@tobrun tobrun removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Nov 5, 2018
@tobrun
Copy link
Member Author

tobrun commented Nov 5, 2018

@LukasPaczos I was able to fixup CamerUpdateFactory#scrollBy by inverting the padding so it can be reapplied by moveTo, easeTo and animateTo. This inversion produces not 100 percent accurate results as I the test need to use a delta for LatLng comparison (see here). The newly exposed MapboxMap#scrollBy doesn't suffer from this (it doesn't hook into moveBy, easeTo or animataTo). so I'm opting to deprecate the CameraUpdateFactory in favor of MapboxMap#scrollBy

@tobrun tobrun merged commit 1c73356 into master Nov 5, 2018
@tobrun tobrun deleted the tvn-moveby branch November 5, 2018 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants