Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove obsolete NativeMapView null-check #13224

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Remove obsolete NativeMapView null-check #13224

merged 1 commit into from
Oct 30, 2018

Conversation

LukasPaczos
Copy link
Member

Fixes #13206. MapView#nativeMapView is now available on MapView object creation, making this null-check obsolete.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Oct 29, 2018
@LukasPaczos LukasPaczos added this to the android-v6.7.0 milestone Oct 29, 2018
tobrun
tobrun approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can we also remove MapView#isMapInitialized?
|It's a private method that is now unused.

@LukasPaczos
Copy link
Member Author

yup, nice catch!

@LukasPaczos LukasPaczos merged commit 2aef28c into master Oct 30, 2018
@LukasPaczos LukasPaczos deleted the lp-13206-is-initialized-check branch October 30, 2018 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v6.7.0-horchata
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasPaczos @tobrun