This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Espresso tests rework #13576
Merged
Espresso tests rework #13576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-espresso-test
branch
3 times, most recently
from
34ff603
to
7133ace
Compare
LukasPaczos
reviewed
Dec 21, 2018
| @@ -27,7 +27,7 @@ public class <%- activity %>Test extends BaseActivityTest { | |||
|
|
|||
| @Test | |||
| public void testSanity() { | |||
| validateTestSetup(); | |||
| // no-op | |||
There was a problem hiding this comment.
Can we remove this test all-together?
There was a problem hiding this comment.
For now I would keep the sanity tests around, updated above block however with assertions for mapboxMap, style and fully loaded.
| public void initMap(MapboxMap mapboxMap) { | ||
| super.initMap(mapboxMap); | ||
| mapboxMap.getStyle(style -> { | ||
| if (resourceCallback != null) { |
There was a problem hiding this comment.
Can we add an assertion checking that the style is fully loaded?
| public void initMap(MapboxMap mapboxMap) { | ||
| super.initMap(mapboxMap); | ||
| mapboxMap.setStyle("asset://streets.json", style -> { | ||
| this.style = style; |
| * Uses {@link LoadStyleIdlingResource} to load "assets/streets.json" as style. | ||
| * </p> | ||
| */ | ||
| public class EspressoActivityTest extends BaseActivityTest { |
There was a problem hiding this comment.
Can we rename EspressoActivityTest to EspressoTest? Similarly with BaseActivityTest. It's a little bit hard to read and distinguish between EspressoTestActivity.
tobrun
force-pushed
the
tvn-espresso-test
branch
from
7133ace
to
c59c7f2
Compare
LukasPaczos
approved these changes
Jan 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a cleanup of our instrumentation tests by making a distinction between tests that:
Notable changes: