This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Updates default styles to streets v11, etc. #13585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
added
iOS
Mapbox Maps SDK for iOS
macOS
Mapbox Maps SDK for macOS
Android
Mapbox Maps SDK for Android
⚠️ DO NOT MERGE
Work in progress, proof of concept, or on hold
Core
The cross-platform C++ core, aka mbgl
labels
Dec 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also need to update this:
mapbox-gl-native/test/util/mapbox.test.cpp
Lines 95 to 97 in f5337a7
"https://api.mapbox.com/styles/v1/mapbox/streets-v10/sprite?access_token=key&fresh=true.png", | |
mbgl::util::mapbox::normalizeSpriteURL(util::API_BASE_URL, | |
"mapbox://sprites/mapbox/streets-v10?fresh=true.png", |
1ec5
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine for iOS and macOS. Suggested changelog entry:
MGLMapView
,MGLShapeOfflineRegion
, andMGLTilePyramidOfflineRegion
now default to version 11 of the Mapbox Streets style. Similarly, several class properties ofMGLStyle
, such asMGLStyle.lightStyleURL
, have been updated to return URLs to new versions of their respective styles.
Thanks @1ec5! |
1ec5
reviewed
Dec 17, 2018
Feel free to merge if all is done on the iOS/macOS side of things. I'm removing the |
fabian-guerra
approved these changes
Dec 17, 2018
julianrex
changed the title
Initial work in updating styles.
Updates default styles to streets v11, etc.
Dec 17, 2018
/cc @agentpu1011 |
julianrex
removed
the
⚠️ DO NOT MERGE
Work in progress, proof of concept, or on hold
label
Dec 18, 2018
captainbarbosa
approved these changes
Dec 18, 2018
4 tasks
Tested on-device, looks good 👍 |
fabian-guerra
pushed a commit
that referenced
this pull request
Jan 7, 2019
# Conflicts: # platform/ios/CHANGELOG.md # platform/macos/CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13553
/cc @LukasPaczos @tmpsantos @1ec5 @nickidlugash