Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Prep work for ios-v4.7.1 #13646

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

captainbarbosa
Copy link
Contributor

@captainbarbosa captainbarbosa commented Dec 21, 2018

Reverts the following commit:

@captainbarbosa captainbarbosa added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Dec 21, 2018
@captainbarbosa captainbarbosa self-assigned this Dec 21, 2018
@captainbarbosa captainbarbosa requested a review from a team December 21, 2018 19:50
@captainbarbosa captainbarbosa force-pushed the prep-ios-v4.7.1 branch 3 times, most recently from c09d826 to 4a381b6 Compare December 21, 2018 20:59
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor missing entry

platform/ios/CHANGELOG.md Outdated Show resolved Hide resolved
Reverts e36e4cf (Parent PR is #13600)

Changelog edits
@@ -15,7 +15,6 @@
* Added support for setting `MGLCollisionBehaviorPre4_0` in `NSUserDefaults`. ([#13426](https://github.com/mapbox/mapbox-gl-native/pull/13426))
* `-[MGLStyle localizeLabelsIntoLocale:]` and `-[NSExpression(MGLAdditions) mgl_expressionLocalizedIntoLocale:]` can automatically localize styles that use version 8 of the Mapbox Streets source. ([#13481](https://github.com/mapbox/mapbox-gl-native/pull/13481))
* Fixed symbol flickering during instantaneous transitions. ([#13535](https://github.com/mapbox/mapbox-gl-native/pull/13535))
* Fixed a crash when specifying `MGLShapeSourceOptionLineDistanceMetrics` when creating an `MGLShapeSource`. ([#13543](https://github.com/mapbox/mapbox-gl-native/pull/13543))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have been reverted. The crash is still fixed.

## 4.7.1 - December 21, 2018

### Styles and rendering
* Reverts the ability for `MGLMapView`, `MGLShapeOfflineRegion`, and `MGLTilePyramidOfflineRegion` to use version 11 of the Mapbox Streets style.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These APIs retain the ability to use the new style versions, if the developer explicitly requests them, just as in previous versions. All that has been reverted is the default behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants