Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Expose query feature extensions #13631

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Dec 20, 2018

Platform binding for ##13382, makes #12726 obsolete.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Dec 20, 2018
@tobrun tobrun added this to the android-v7.1.0 milestone Dec 20, 2018
@tobrun tobrun self-assigned this Dec 20, 2018
@tobrun tobrun force-pushed the tvn-implement-feature-extensions branch 2 times, most recently from 779abb8 to 6a42754 Compare January 9, 2019 12:39
@tobrun tobrun force-pushed the tvn-implement-feature-extensions branch 4 times, most recently from 159774c to 44db1e0 Compare January 10, 2019 16:58
@tobrun
Copy link
Member Author

tobrun commented Jan 10, 2019

@alexshalamov & @LukasPaczos, this PR is ready for review.
Manual test added looks like:

ezgif com-video-to-gif 48

@tobrun
Copy link
Member Author

tobrun commented Jan 14, 2019

@alexshalamov would you be able to do an initial review of the c++ code?

Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments. Otherwise 👍 looks good!

@tobrun tobrun force-pushed the tvn-implement-feature-extensions branch from 44db1e0 to b3b4157 Compare January 15, 2019 15:20
@LukasPaczos LukasPaczos deleted the tvn-implement-feature-extensions branch January 15, 2019 15:34
@LukasPaczos LukasPaczos restored the tvn-implement-feature-extensions branch January 15, 2019 15:35
@tobrun tobrun reopened this Jan 15, 2019
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Java perspective 🚀

@tobrun tobrun merged commit 9ba0737 into master Jan 15, 2019
@tobrun tobrun deleted the tvn-implement-feature-extensions branch January 15, 2019 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants