This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove faulty cast to uint64_t, explict casting for cluster API #13888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-uint64_t
branch
2 times, most recently
from
c550e53
to
a09c35f
Compare
LukasPaczos
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13631 introduced a regression in our JsonElement conversion system. For the cluster API we added support for converting to uint64_t but not all json primitives should have been processed that way. Atm there isn't an easy fix as JsonElement from GSON uses the Number interface. While it exposes a couple of conversions it doesn't fully support the API to determine C++ types from.
This issue closes #13881 for the meantime, as this PR reverts back to the old behavior and add some additional casting to our cluster API to keep that API functional.
Will create a follow up ticket and link it back to this PR.