This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core,ios,android] Update feedback URL in code and tests #13710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Jan 10, 2019
|
@julianrex @tmpsantos would appreciate your eyes when you have a chance to make sure I didn't break anything on the iOS or core sides. |
julianrex
approved these changes
Jan 11, 2019
1ec5
approved these changes
Jan 11, 2019
tobrun
suggested changes
Jan 15, 2019
There was a problem hiding this comment.
Was looking into #13715 which resulted in PR'ing https://github.com/mapbox/mapbox-gl-native/pull/13732/files. It seems backend is still returning www.mapbox.com/map-feedback. Since we rely on locally parsing the URL (and redirects won't help us here), we should not update the android code until backend actually returns the correct url.
Merged
…ps.mapbox.com/feedback
…s.mapbox.com/feedback
tobrun
force-pushed
the
az-feedback-link
branch
from
68c4a51
to
3418970
Compare
tobrun
approved these changes
Jan 17, 2019
tmpsantos
approved these changes
Jan 17, 2019
|
Thank you, @tobrun, for fixing it up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently switched from
www.mapbox.com/feedbacktoapps.mapbox.com/feedbackas the preferred way to provide feedback. Before that, we switched fromwww.mapbox.com/map-feedbacktowww.mapbox.com/feedback. This PR updates all occurrences of old URLs to the newappsone.Fixes #13697.