This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Snapshot attribution #13732
Merged
Snapshot attribution #13732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasPaczos both PRs break the functionality that this PR is addressing, see #13710 (review) for more context. |
LukasPaczos
approved these changes
Jan 15, 2019
I'm going to revisit this PR to make changing URLs backwards compatible. |
LukasPaczos
reviewed
Jan 15, 2019
...m/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/attribution/Attribution.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-snapshot-attribution
branch
from
14cff23
to
773de99
Compare
tobrun
force-pushed
the
tvn-snapshot-attribution
branch
from
773de99
to
a736fb6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13715. it now generates attribution correctly: