This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Feature: Change path of the resources cache db (CP #13707) #13947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
Android
LukasPaczos
force-pushed
the
lp-cp-13707-origin
branch
2 times, most recently
from
51dfa45
to
e5fa928
Compare
tmpsantos
reviewed
Mar 8, 2019
| void OfflineDatabase::changePath(const std::string& path_) { | ||
| Log::Info(Event::Database, "Changing the database path."); | ||
|
|
||
| statements.clear(); |
There was a problem hiding this comment.
This is what we call on the destructor. This functions might throw and we should catch. To avoid duplicating the code, make both the destructor and this function call something like OfflineDatabase::cleanup
LukasPaczos
force-pushed
the
lp-cp-13707-origin
branch
2 times, most recently
from
fa9701e
to
82d4aab
Compare
LukasPaczos
force-pushed
the
lp-cp-13707-origin
branch
from
82d4aab
to
734b217
Compare
|
Ready for another round. |
tobrun
reviewed
Mar 13, 2019
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/storage/FileSource.java
Show resolved
Hide resolved
.../main/java/com/mapbox/mapboxsdk/testapp/activity/offline/ChangeResourcesCachePathActivity.kt
Outdated
Show resolved
Hide resolved
tobrun
reviewed
Mar 13, 2019
.../main/java/com/mapbox/mapboxsdk/testapp/activity/offline/ChangeResourcesCachePathActivity.kt
Outdated
Show resolved
Hide resolved
The idea is that https://github.com/mapbox/mapbox-gl-native/pull/13947/files#diff-bfa4af72183147adf9f916e65d5e64c3R278 guards against those, do you see a better way? |
…of the whole FileSource
LukasPaczos
force-pushed
the
lp-cp-13707-origin
branch
from
734b217
to
c39782b
Compare
tobrun
approved these changes
Mar 13, 2019
|
Thank you for the refactoring and merging @LukasPaczos ! Unfortunately I found a bug: #14297 |
LukasPaczos
added a commit
that referenced
this pull request
Apr 4, 2019
LukasPaczos
added a commit
that referenced
this pull request
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPs #13707 and changes the reinitialization flow to reset the database instead of the whole
FileSource.Again, thanks a lot for the contribution @arnekaiser!