[core] Render pipeline refactoring #14385

pozdnyakov · 2019-04-10T12:59:22Z

This patch does the following:

provides generic mechanism to synchronize buckets and layer paint properties (applied for the layers that render geometry tiles data, i.e. symbol, line, fill, fill-extrusion, heatmap, circle)
introduces new immutable style::LayerProperties and LayerRenderData types, which is a step towards separate render thread.
encapsulates layer paint properties initialization
encapsulates render tile initialization
multiple simplifications and refactoring

Fixes #13812

src/mbgl/layermanager/fill_layer_factory.cpp

src/mbgl/style/layers/background_layer_properties.hpp

src/mbgl/renderer/tile_pyramid.cpp

alexshalamov

lgtm with nits

alexshalamov · 2019-04-17T11:52:10Z

src/mbgl/tile/geometry_tile_worker.cpp

@@ -412,7 +392,7 @@ void GeometryTileWorker::parse() {
            }

            for (const auto& layer : group) {
-                buckets.emplace(layer->baseImpl->id, bucket);
+                renderData.emplace(layer->baseImpl->id, LayerRenderData{bucket, layer});


std::move(bucket)?

bucket is shared between several items

src/mbgl/tile/geometry_tile.cpp

alexshalamov · 2019-04-17T12:00:28Z

src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp

+                        const auto& evaluated_,
+                        const auto& crossfade_,
+                        const auto& tileBucket,
+                        auto&& uniformValues,


const auto&

it is invoked with a temporary

alexshalamov · 2019-04-17T12:00:37Z

src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp

                        const optional<ImagePosition>& patternPositionA,
-                        const optional<ImagePosition>& patternPositionB, auto&& textureBindings) {
+                        const optional<ImagePosition>& patternPositionB,
+                        auto&& textureBindings) {


const auto&

and remove moves in draw call below

…ations

…outs.

…operties.

Actual for layers rendering the geometry tile data: line, fill, fill-extrusion, heatmap, circle, symbol (was updated in previous commits).

pozdnyakov force-pushed the mikhail_sync_buckets_and_paint_properties branch from 9997c34 to 8f54901 Compare April 10, 2019 13:15

pozdnyakov requested review from kkaefer, alexshalamov and tmpsantos April 10, 2019 14:00

pozdnyakov added Core The cross-platform C++ core, aka mbgl refactor labels Apr 10, 2019

alexshalamov reviewed Apr 11, 2019

View reviewed changes

src/mbgl/layermanager/fill_layer_factory.cpp Outdated Show resolved Hide resolved

src/mbgl/style/layers/background_layer_properties.hpp Outdated Show resolved Hide resolved

src/mbgl/renderer/tile_pyramid.cpp Outdated Show resolved Hide resolved

pozdnyakov force-pushed the mikhail_sync_buckets_and_paint_properties branch 3 times, most recently from 5439462 to 06bc2ea Compare April 11, 2019 14:41

alexshalamov approved these changes Apr 17, 2019

View reviewed changes

pozdnyakov added 7 commits April 17, 2019 15:13

[core] Introduce style::LayerProperties interface and its implement…

daf88ec

…ations

[core] Use style::LayerProperties in render layers, buckets and lay…

e59e3f9

…outs.

[core] Introduce LayerRenderData. Source::update() accepts layer pr…

de18ae0

…operties.

[core] Add FadingTiles layer type property

cc1b6a9

[core] Update style::LayerProperties instances in tiles

46f5471

[core] Simplify RenderLayer interface.

2630b59

[core] Render layers use synchronized buckets and paint properties

4ceb3e6

Actual for layers rendering the geometry tile data: line, fill, fill-extrusion, heatmap, circle, symbol (was updated in previous commits).

pozdnyakov force-pushed the mikhail_sync_buckets_and_paint_properties branch from 06bc2ea to 4ceb3e6 Compare April 17, 2019 13:44

pozdnyakov merged commit 8580971 into master Apr 17, 2019

pozdnyakov deleted the mikhail_sync_buckets_and_paint_properties branch April 17, 2019 14:21

kkaefer mentioned this pull request Apr 26, 2019

Change approach to stencil clipping to (almost) match JS #14438

Merged

asheemmamoowala mentioned this pull request Jun 27, 2019

[core] Tile updates the contained layer properties based on constants mask #15016

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Render pipeline refactoring #14385

[core] Render pipeline refactoring #14385

pozdnyakov commented Apr 10, 2019 •

edited

Loading

alexshalamov left a comment

alexshalamov Apr 17, 2019

pozdnyakov Apr 17, 2019

alexshalamov Apr 17, 2019

pozdnyakov Apr 17, 2019

alexshalamov Apr 17, 2019

[core] Render pipeline refactoring #14385

[core] Render pipeline refactoring #14385

Conversation

pozdnyakov commented Apr 10, 2019 • edited Loading

alexshalamov left a comment

Choose a reason for hiding this comment

alexshalamov Apr 17, 2019

Choose a reason for hiding this comment

pozdnyakov Apr 17, 2019

Choose a reason for hiding this comment

alexshalamov Apr 17, 2019

Choose a reason for hiding this comment

pozdnyakov Apr 17, 2019

Choose a reason for hiding this comment

alexshalamov Apr 17, 2019

Choose a reason for hiding this comment

pozdnyakov commented Apr 10, 2019 •

edited

Loading