This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Tile updates the contained layer properties based on constants mask #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pozdnyakov Does this change and #14385 need to be ported to GL-JS as well? |
AFAIK gl-js is also preparing buckets in the tile worker thread, so buckets can get out of sync with the evaluated properties in meantime. These changes could be applied to fix this issue. |
tmpsantos
approved these changes
Jun 28, 2019
friedbunny
added
the
needs changelog
Constants mask for data-driven paint properties is a reliable criteria of whether the given updated properties can still be used with the existing bucket (and the gl program instance).
…remains Thus, we do not have to wait for tile update completion in case the updated properties have the same constants mask, i.e. fit the existing bucket.
pozdnyakov
force-pushed
the
mikhail_fix_layer_paint_properties_update
branch
from
0dae679
to
bb5d638
Compare
pozdnyakov
force-pushed
the
mikhail_fix_layer_paint_properties_update
branch
2 times, most recently
from
46840ec
to
bb5d638
Compare
friedbunny
removed
the
needs changelog
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use layer data-driven properties constants mask to verify that the given layer properties are compatible with the existing buckets.
Thus, the updated paint properties can applied for rendering even before the tile re-layout completes.
Fixes: #14939