Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Remove previously deprecated unavailable methods and properties #15000

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Jun 25, 2019

Removes previously deprecated methods and properties that had been marked as unavailable at least a year ago in #11205 (and usually several years ago).

Also updates some MGLOfflineStorage documentation to use the current key names.

/cc @mapbox/maps-ios

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS refactor labels Jun 25, 2019
@friedbunny friedbunny added this to the release-p milestone Jun 25, 2019
@friedbunny friedbunny requested review from 1ec5, julianrex and a team June 25, 2019 18:52
@friedbunny friedbunny self-assigned this Jun 25, 2019
Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@friedbunny
Copy link
Contributor Author

Here’s what apidiff looks like for these changes...

MGLAccountManager

removed class method: +[MGLAccountManager mapboxMetricsEnabledSettingShownInApp] + undoc

MGLOfflinePackProgressUserInfoKey

removed constant: MGLOfflinePackProgressUserInfoKey + undoc

MGLStyle

removed class method: +[MGLStyle trafficDayStyleURL] + undoc

removed class method: +[MGLStyle trafficDayStyleURLWithVersion:] + undoc

removed class method: +[MGLStyle trafficNightStyleURL] + undoc

removed method: -[MGLStyle addStyleClass:] + undoc

removed class method: +[MGLStyle trafficNightStyleURLWithVersion:] + undoc

removed class method: +[MGLStyle emeraldStyleURL] + undoc

removed property: MGLStyle.localizesLabels + undoc

removed method: -[MGLStyle removeStyleClass:] + undoc

removed class method: +[MGLStyle hybridStyleURL] + undoc

removed method: -[MGLStyle hasStyleClass:] + undoc

removed property: MGLStyle.styleClasses + undoc

MGLOfflinePackMaximumCountUserInfoKey

removed constant: MGLOfflinePackMaximumCountUserInfoKey + undoc

MGLOfflinePackErrorUserInfoKey

removed constant: MGLOfflinePackErrorUserInfoKey + undoc

MGLMapView

removed method: -[MGLMapView addStyleClass:] + undoc

removed property: MGLMapView.styleClasses + undoc

removed method: -[MGLMapView emptyMemoryCache] + undoc

removed method: -[MGLMapView metersPerPixelAtLatitude:] + undoc

removed method: -[MGLMapView hasStyleClass:] + undoc

removed property: MGLMapView.debugActive + undoc

removed property: MGLMapView.bundledStyleURLs + undoc

removed method: -[MGLMapView toggleDebug] + undoc

removed method: -[MGLMapView removeStyleClass:] + undoc

MGLOfflinePackStateUserInfoKey

removed constant: MGLOfflinePackStateUserInfoKey + undoc

@julianrex
Copy link
Contributor

For reference these were marked unavailable in the 4.0.0 release, and ideally would have been removed in 5.0.0.

@friedbunny friedbunny force-pushed the friedbunny-removes-some-long-deprecated-stuff branch from a3eabdf to e26a60d Compare June 26, 2019 20:36
@friedbunny friedbunny merged commit e26a60d into master Jun 26, 2019
@friedbunny friedbunny deleted the friedbunny-removes-some-long-deprecated-stuff branch June 26, 2019 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants