This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Port line-dasharray fix from gl-js #16202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
added
GL JS parity
There was a problem hiding this comment.
@karimnaaji could you 'unignore'
Patch for baselines bot could be downloaded from CI job https://406842-16286131-gh.circle-artifacts.com/0/tests/baselines/baselines.patch
|
Thanks for the info on the baselines @alexshalamov ! It's updated, ready for another review. |
alexshalamov
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
lgtm and thanks for backport!
Could you please add entry to changelog
karimnaaji
removed
the
needs changelog
tmpsantos
approved these changes
Feb 14, 2020
* Fix artifact for zero-lenghted dash array Fixes issue mapbox/mapbox-gl-js#9213 and add render test for coverage around 0-length dash arrays Update distance field generation for regular dashes as follows: 1. Compute the dash array ranges and stretch location along the distance field 2. Collapse any 0-length distance field range 3. Collapse neighbouring same-type parts into single part * combine consecutive dashes and parts mapbox/mapbox-gl-js#9246 #16181
alexshalamov
force-pushed
the
line-dash-array-fix
branch
from
36f4554
to
85e3aec
Compare
|
@karimnaaji rebased & meged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of bug-fix on line-dasharray from gl-js.
For background, refer:
Closes #16181
Launch Checklist
needs changeloglabel if a changelog is needed (remove label when added)