-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karimnaaji could you 'unignore'
"render-tests/line-dasharray/zero-length-gap":"https://github.com/mapbox/mapbox-gl-js/pull/9246" |
Patch for baselines bot could be downloaded from CI job https://406842-16286131-gh.circle-artifacts.com/0/tests/baselines/baselines.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments
Thanks for the info on the baselines @alexshalamov ! It's updated, ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and thanks for backport!
Could you please add entry to changelog
* Fix artifact for zero-lenghted dash array Fixes issue mapbox/mapbox-gl-js#9213 and add render test for coverage around 0-length dash arrays Update distance field generation for regular dashes as follows: 1. Compute the dash array ranges and stretch location along the distance field 2. Collapse any 0-length distance field range 3. Collapse neighbouring same-type parts into single part * combine consecutive dashes and parts mapbox/mapbox-gl-js#9246 #16181
36f4554
to
85e3aec
Compare
@karimnaaji rebased & meged. |
Port of bug-fix on line-dasharray from gl-js.
For background, refer:
Closes #16181
Launch Checklist
needs changelog
label if a changelog is needed (remove label when added)