This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Ability to set generic layer properties using setProperty method #16324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
changed the title
pozdnyakov
force-pushed
the
mikhail_base_layer_setters
branch
from
2e03ca1
to
80d7233
Compare
src/mbgl/style/layer.cpp
Outdated
| return nullopt; | ||
| } | ||
| } | ||
| return error; // Must be Error{"layer doesn't support this property"}. |
There was a problem hiding this comment.
nit: Could be conversion error.
pozdnyakov
force-pushed
the
mikhail_base_layer_setters
branch
from
80d7233
to
0b33118
Compare
pozdnyakov
force-pushed
the
mikhail_base_layer_setters
branch
from
0b33118
to
ff8ffa1
Compare
alexshalamov
approved these changes
Mar 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the following new keys for the
mbgl::Layer::setProperty()APIsetFilter()setMinZoom()setMaxZoom()setSourceLayer()The newly-added API is used in the style-conversion code, which made this code much simpler.
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/220