Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use array of structs rather than parallel arrays for annotations #1710

Merged
merged 1 commit into from Jun 11, 2015

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Jun 11, 2015

Our current point annotations API uses two parallel vectors for points and icon names which leaves room for errors due to mismatched annotations. Instead, we should use an array of structs so the association between point and icon is fixed and not through the index.

@kkaefer kkaefer self-assigned this Jun 11, 2015
@1ec5
Copy link
Contributor

1ec5 commented Jun 11, 2015

👍

@kkaefer kkaefer force-pushed the 1710-point-annotation-vector branch from 46a7864 to 2435c1a Compare June 11, 2015 21:26
@kkaefer kkaefer merged commit 2435c1a into master Jun 11, 2015
@kkaefer kkaefer deleted the 1710-point-annotation-vector branch June 11, 2015 21:37
@1ec5 1ec5 restored the 1710-point-annotation-vector branch June 15, 2015 22:54
1ec5 added a commit that referenced this pull request Jun 15, 2015
…ons"

This reverts commit 2435c1a (#1710), which needs to be revisited in light of #1655, which is a much higher priority at the moment.
@1ec5
Copy link
Contributor

1ec5 commented Jun 15, 2015

@kkaefer, per chat with @incanus, I reverted this change in 714b68f, because it complicated landing #1655. I like the idea of making annotations more object-oriented at the mbgl level, but that’s a lower priority than landing shape annotations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants