This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] #5276 - icon should be optional for MarkerView #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where a moved {GL,TexturePool}Holder would use an invalid
pointer when accessing 'objectStore'.
Fixes #5136.
Prevents confusing usage of GL holder objects.
This adds an option to MGLAnnotationView so that a developer can control how their annotation views scale in size as they approach the top of the map view (along the Y axis). The size change is also affected by the pitch (tilt) of the map view. If there is no tilt then scaling is not performed. As the map is tilted scaling is gradually applied. This turns the MGLAnnotationView implementation into an Objective C++ class so that SDK constants from C++ files can be used. The new behavior is enabled by default to maintain consistency with annotations backed by GL sprites. The MBXViewController redundantly sets the new property as an illustration of use.
* Location logs are not just kept on the device. * Some logging packages, e.g., Firebase, now has the option to upload logs to cloud. * This closes a potential privacy leak.
Same as 2f25c1a, but for OS X.
… the first frame On the Javascript implementation the array is automatically filled with zeroes which is not the same thing as `TimePoint::min()`. Here we need to get our own "zero" which is the timestamp of the first frame. Fixes #5109
…5164) This forces the call of the map view's display link target when the display link is created. When a map view is shown the first time this is not required. However, if the display link was torn down and then recreated due to the map view being removed / obscured in the view hierarchy the map view delegate may expect to be informed when the map view did finish loading the map when it is shown again. This adds a call to `updateFromDisplayLink` just after a display link is created which helps trigger a full refresh of the map in the sense that all delegate methods get exercised including `mapViewDidFinishLoadingMap`.
Change domain from api -> events Replace old certs with new ones with the same name. The new certs have an expiry that is further out.
Added methods to MGLMapView that return the rendered features at a visible point or within a visible rectangle on the map, optionally restricted to a set of layers, plus voluminous documentation. Added several new geometry classes corresponding to distinct geometry types supported by geometry.hpp. Added parallel “feature” classes to represent these geometries along with tags (IDs) and attributes (properties) from the source. Grouped classes in the Foundation and SDK groups by theme. In iosapp, dropped pins’ callout views now display the name of the topmost named feature at that point. In osxapp, a long press on the map highlights the features under the cursor. Dropping a pin via the menu or context menu item shows the usual dropped pin, but the pin’s title is now the name of a feature under the cursor, if available, rather than “Dropped Pin”. Fixes the iOS/OS X side of #352.
Made writability of MGLFeature properties private, to avoid having to awkwardly explain that changes to the properties don’t change the map (maybe someday they will). This allows the identifier and attributes to be set in only one place, avoiding copy-pasta.
MGLPolygon (and by extension MGLMultiPolygon) now supports interior rings. The data is preserved in feature querying results, and interior rings are respected when adding polygon overlays to the map. Fixes #1729. [ios, osx] Updated changelog
Removed a level of indirection when creating Objective-C collections from C++ collections. Adopted mbgl typedefs for geometry.hpp types. Factored out MGLPolygon construction.
Ignore any multipolyline, multipolygon, or shape collection object passed into -addAnnotation: or -addAnnotations:. Previously, these methods broke apart the compound shape into its constituent shapes in order to recursively add them to the map. But that broke assumptions about a one-to-one correspondence between annotations and their contexts during selection and deletion.
Moved feature selection to the context menu and restored the press gesture for dropping a pin. Bust complex features into simple shapes to feed into MGLMapView as overlays.
Ported the following patches: - [convert mat4 exMatrix to a vec2 extrudeScale](mapbox/mapbox-gl-shaders@a8d549b) - [Enabled data-driven styling for circle-radius](mapbox/mapbox-gl-shaders@4356e41) - [Reduce shader boilerplate, refactor "Bucket"](mapbox/mapbox-gl-shaders@7d3da8f)
Shader parent object has been safely created, so it is safe to initialize the *Shader attributes via initialization list.
Added MGLAnnotationView to jazzy’s table of contents.
We've recently moved from Release to Debug default build type.
* First pass at port of mapbox/mapbox-gl-js#2668 * RotationAlignmentType => AlignmentType * Handle undefined default value for text-pitch-alignment and implement inheritance for this value from text-rotation-alignment * Update dependencies * Move handling fo undefined default value out of camelize functions
|
Thanks for picking this up @tobrun. One question though, why bundle and use |
|
The gl marker:
The view marker:
The problem we had with GL markers is that we didn't have a way to do anchoring/offsets. To be able to put the bottom of the marker at the correct position, we had to add extra transparent pixels. Now with view markers we have anchors and they are by default placed at the bottom of the image. This is what @cammace was indicating in #5276 (comment) with:
|
|
CI approved, going to rebase and merge |
tobrun
force-pushed
the
5276-icon-should-be-optional
branch
from
b1afa8a
to
ac30ee1
Compare
|
rebased against master instead of release and only noticed after force pushing, follow up PR in #5348 |
Thanks for the details in the thinking behind this. Can you help me understand why the solution wasn't to fix the Core GL markers then instead of duplicating default markers? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the crash when trying to add a MarkerView without an icon. This PR introduces a default icon for MarkerView. We can't reuse the icon from Marker since that has extra transparent pixels
closes #5276
cc @bleege @cammace @ivovandongen @zugaldia