Optimize animated annotations #5385
Conversation
| DroppedPinAnnotation *annotation = [[DroppedPinAnnotation alloc] init]; | ||
| [self.mapView addAnnotation:annotation]; | ||
|
|
||
| [NSTimer scheduledTimerWithTimeInterval:1/60 |
There was a problem hiding this comment.
The time interval is 0 since no floats are involved.
There was a problem hiding this comment.
It was copied from dropManyPins:. I'll fix both occurrences.
|
@jfirebaugh this a major improvement, we aren't dropping any frames anymore with this fix. |
|
I'm having some issues bringing this from To test, I reversed the approach and cherry picked the animating car example from
Here is also an example with +100 markers:
|
|
Ported by hand to the Android release branch in |
|
@jfirebaugh This is the
This is the same activity brought to your
Bottom line, your port is improving substantially the performance. Let's merge it into the release branch 👍 . |
|
@jfirebaugh Bringing |
In particular, if only the geometry changes, don't cascade and recalculate the style.
jfirebaugh
force-pushed
the
animated-annotation
branch
from
1e2d0fb
to
2921127
Compare
|
getting a bunch of output in logcat which makes it impossible to read without filtering. Anyway we could remove this from printing? |
|
@cammace you can disable this type of logging if you build with BUILDTYPE=Release |
I added an "Add Animated Annotation" menu item in the macOS test app, and then profiled it, which revealed several gross inefficiencies. After fixing those, the profile is heavily dominated by rendering performance -- updating the annotation is less than 3% of runtime.
@tobrun, can you test this out on Android?
/cc @1ec5 for macOS test app changes.