This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix rendering 180° line joins #7786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
force-pushed
the
7778-acute-line-join-artifacts
branch
from
af3c8e7
to
b2de339
Compare
kkaefer
force-pushed
the
7778-acute-line-join-artifacts
branch
from
b2de339
to
3610f2e
Compare
|
Enabled test suite in mapbox/mapbox-gl-js@2663093 |
1ec5
added a commit
that referenced
this pull request
Feb 9, 2017
1ec5
added a commit
that referenced
this pull request
Feb 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7778, a alternative fix for mapbox/mapbox-gl-js#4008
@lbud I am using a different fix: I found that computing the unit vector of (0, 0) on native returns a vector of (0, 0), while JS uses NaN. I investigated a little further and ultimately found that this makes
miterLengthNaN as well on JS. Instead of using NaN all the way down, this patch uses an explicit value of0, and sets themiterLimitto Infinity in that case. This change also fixes the missing line caps we saw on native (which was also a result of the different way of computingunit(0, 0)).I think we should port this change back to JS as well, since it removes division by zero.