Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android: Refactor Mapbox singleton initialization #8095

Closed
wants to merge 1 commit into from

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Feb 17, 2017

No description provided.

@kkaefer kkaefer requested a review from tobrun February 17, 2017 14:50
@mention-bot
Copy link

@kkaefer, thanks for your PR! By analyzing this pull request, we identified @zugaldia to be potential reviewers.

@kkaefer kkaefer force-pushed the android-access-token-validation branch from 7ca7fad to 9f1ffdd Compare February 17, 2017 15:08
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and agreed to this change but what issue is it resolving?

@kkaefer
Copy link
Contributor Author

kkaefer commented Feb 21, 2017

Long term goal is to remove parameters from .getInstance() calls, since this allows passing different parameters in different invocations, but we only have the one singleton from the first invocation.

@friedbunny friedbunny added Android Mapbox Maps SDK for Android refactor labels Feb 21, 2017
@jfirebaugh
Copy link
Contributor

Stale.

@jfirebaugh jfirebaugh closed this Oct 24, 2017
@jfirebaugh jfirebaugh deleted the android-access-token-validation branch October 24, 2017 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants