Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Set project deployment target to iOS 8 #8129

Merged
merged 4 commits into from
Feb 22, 2017
Merged

[ios] Set project deployment target to iOS 8 #8129

merged 4 commits into from
Feb 22, 2017

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Feb 20, 2017

With Xcode 8 having dropped support for iOS 7 and Apple declaring it dangerously insecure, it’s come time to move our minimum deployment version to iOS 8.

Notes

  • The static framework build infrastructure still exists, but for how much longer is unclear.
  • The dynamic framework has been our recommended path since Mapbox iOS SDK v3.1.0 (released February 2016) and developers should migrate to it as soon as possible, if they haven’t already.
  • UIActionSheet and UIAlertView remain in use for the attribution button, despite being deprecated in favor of UIAlertController. UIAlertController is a view controller (as opposed to views, previously), which presents a variety of issues to us as framework vendors that we’ll need to consider before adoption.
  • There is no change to the hardware we support — we already explicitly did not support iPhone 4, fourth-generation iPod Touch, or the first-generation iPad.

/cc @mapbox/ios

@friedbunny friedbunny added build documentation iOS Mapbox Maps SDK for iOS labels Feb 20, 2017
@friedbunny friedbunny added this to the ios-v3.5.0 milestone Feb 20, 2017
@friedbunny friedbunny self-assigned this Feb 20, 2017
@mention-bot
Copy link

@friedbunny, thanks for your PR! By analyzing this pull request, we identified @1ec5, @incanus and @boundsj to be potential reviewers.

@1ec5
Copy link
Contributor

1ec5 commented Feb 21, 2017

The static framework build infrastructure still exists, but for how much longer is unclear.

To be clear, we currently have no plans to drop the static framework and will provide advance notice before doing so.

@@ -52,8 +52,6 @@ bash "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Mapbox.framework/strip-fra

#### Static framework

If your application targets iOS 7.x, you’ll need to install the static framework instead:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave in a sentence just to make it clear that these are alternative instructions, not additive. "If you need a static framework…"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled to come up with anything here — “if you can’t say anything nice...” 😉

Will revisit this tomorrow. Very open to detailed suggestions!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s the “You know who you are” version:

You can alternatively install the SDK as a static framework:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this in a1c477b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build documentation iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants