This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Add pause/resume to the Thread class #8194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a thread completely halt and not process any message on the message queue until resume() is called. Sending a sync message to a halted thread will result on a deadlock, thus the assertion. Deleting a paused thread will trigger a resume.
It will halt the networking thread completely. Expired and error'ed tiles won't get re-requested until resume() is called again.
Simple test of the DefaultFileSource pause/resume API.
|
@tmpsantos, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @ansis and @incanus to be potential reviewers. |
jfirebaugh
approved these changes
Feb 24, 2017
boundsj
approved these changes
Feb 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a thread completely halt and not process any message on the message queue until resume() is called.
Sending a sync message to a halted thread will result on a deadlock, thus the assertion.
Deleting a paused thread will trigger a resume.