Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Set firsRender flag to false when destroying the surface #8739

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Set firsRender flag to false when destroying the surface #8739

merged 1 commit into from
Apr 19, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Apr 13, 2017

Closes #8725
Closes #6647

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Apr 13, 2017
@tobrun tobrun added this to the android-v5.1.0 milestone Apr 13, 2017
@tobrun tobrun self-assigned this Apr 13, 2017
ivovandongen
ivovandongen approved these changes Apr 13, 2017
View reviewed changes
Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to have a way to reproduce this? Otherwise fine.

@tobrun
Copy link
Member Author

tobrun commented Apr 19, 2017

@ivovandongen tried reproducing but couldn't trigger it, though the change makes sense imo.
Do you want to take a stab at reproducing before merging?

@tobrun tobrun merged commit 090677a into master Apr 19, 2017
@tobrun tobrun deleted the 8725-first-render-true-on-destroy branch April 21, 2017 09:08
@tobrun tobrun mentioned this pull request May 2, 2017
Closed
12 tasks
This was referenced May 18, 2017
Closed
Closed
@tobrun tobrun mentioned this pull request Jun 9, 2017
Closed
12 tasks
@tobrun tobrun mentioned this pull request Jun 21, 2017
Closed
11 tasks
@tobrun tobrun mentioned this pull request Jun 30, 2017
Closed
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ivovandongen ivovandongen ivovandongen approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobrun @ivovandongen